Add cloud download icon and improve update UI handling

Update UI to use CloudDownload icon instead of RefreshCw Improve error handling for update checks Add better visual feedback for update states Change GitHub link to RealManual repository
2026-06-15 14:36:30 +07:00
parent 74abea5467
commit 614d7fea06
3 changed files with 24 additions and 26 deletions
@@ -449,32 +449,28 @@ fn parse_ver(v: &str) -> (u64, u64, u64) {
 /// which `make dmg` bumps on every build.
 #[tauri::command]
 pub async fn check_update(app: AppHandle) -> Result<UpdateInfo, String> {
+    // The local version is always known; the server may be unreachable (no manifest
+    // yet, offline). Never fail the command for that — return the current version with
+    // an empty `latest` so the UI can show "couldn't check" instead of blanking out.
    let current = app.package_info().version.to_string();
+    let fallback_url = "https://spaceshell.ru/download/spacesh.dmg".to_string();
    let manifest_url =
        std::env::var("SPACESH_UPDATE_URL").ok().filter(|s| !s.is_empty()).unwrap_or_else(|| DEFAULT_UPDATE_URL.to_string());

-    let client = reqwest::Client::builder()
-        .timeout(Duration::from_secs(10))
-        .build()
-        .map_err(|e| e.to_string())?;
-    let manifest: Value = client
-        .get(&manifest_url)
-        .send()
-        .await
-        .map_err(|e| e.to_string())?
-        .json()
-        .await
-        .map_err(|e| e.to_string())?;
+    let fetch = || async {
+        let client = reqwest::Client::builder().timeout(Duration::from_secs(10)).build()?;
+        client.get(&manifest_url).send().await?.error_for_status()?.json::<Value>().await
+    };

-    let latest = manifest.get("version").and_then(|v| v.as_str()).unwrap_or("").to_string();
-    let url = manifest
-        .get("url")
-        .and_then(|v| v.as_str())
-        .unwrap_or("https://spaceshell.ru/download/spacesh.dmg")
-        .to_string();
-    let has_update = !latest.is_empty() && parse_ver(&latest) > parse_ver(&current);
-
-    Ok(UpdateInfo { current, latest, has_update, url })
+    match fetch().await {
+        Ok(manifest) => {
+            let latest = manifest.get("version").and_then(|v| v.as_str()).unwrap_or("").to_string();
+            let url = manifest.get("url").and_then(|v| v.as_str()).unwrap_or(&fallback_url).to_string();
+            let has_update = !latest.is_empty() && parse_ver(&latest) > parse_ver(&current);
+            Ok(UpdateInfo { current, latest, has_update, url })
+        }
+        Err(_) => Ok(UpdateInfo { current, latest: String::new(), has_update: false, url: fallback_url }),
+    }
 }

 /// Open a URL in the default browser (macOS `open`). Used by the update popover's